kyonshi/grenzland-mud
1
0
Fork 1
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove undefined behaviour

Browse Source
This commit is contained in:
welcor
2024-06-21 14:07:20 +02:00
parent 59e2e4f180
commit 81e0eb009a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/handler.c
View File

@@ -592,14 +592,16 @@ int get_number(char **name)
{ {
int i; int i;
char *ppos; char *ppos;
char number[MAX_INPUT_LENGTH]; char number[MAX_INPUT_LENGTH], tmp[MAX_INPUT_LENGTH];
*number = '\0'; *number = '\0';
if ((ppos = strchr(*name, '.')) != NULL) { if ((ppos = strchr(*name, '.')) != NULL) {
*ppos++ = '\0'; *ppos++ = '\0';
strlcpy(number, *name, sizeof(number)); strlcpy(number, *name, sizeof(number));
strcpy(*name, ppos); /* strcpy: OK (always smaller) */ // avoid overlapping strings in strcpy which is undefined behaviour
strcpy(tmp, ppos); /* strcpy: OK (always smaller) */
strcpy(*name, tmp); /* strcpy: OK (always smaller) */
for (i = 0; *(number + i); i++) for (i = 0; *(number + i); i++)
if (!isdigit(*(number + i))) if (!isdigit(*(number + i)))