kyonshi/tbamud
1
0
Fork 0
mirror of https://github.com/tbamud/tbamud.git synced 2026-04-30 04:41:51 +02:00
Code Issues Packages Projects Releases Wiki Activity

Potential fix for code scanning alert no. 55: Call to alloca in a loop (#175)

Browse Source 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This commit is contained in:
Thomas Arp
2026-04-21 23:20:23 +02:00
committed by GitHub
parent d4089c58e8
commit 10251814f6
1 changed files with 15 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/protocol.c
View File

@@ -2102,20 +2102,25 @@ static void ExecuteMSDPPair( descriptor_t *apDescriptor, const char *apVariable,
!strcmp(apDescriptor->pProtocol->pVariables[i]->pValueString, "Unknown") ) !strcmp(apDescriptor->pProtocol->pVariables[i]->pValueString, "Unknown") )
{ {
/* Store the new value if it's valid */ /* Store the new value if it's valid */
char *pBuffer = alloca(VariableNameTable[i].Max+1); char *pBuffer = malloc(VariableNameTable[i].Max + 1);
int j; /* Loop counter */ int j; /* Loop counter */
for ( j = 0; j < VariableNameTable[i].Max && *apValue != '\0'; ++apValue ) if ( pBuffer != NULL )
{ {
if ( isprint(*apValue) ) for ( j = 0; j < VariableNameTable[i].Max && *apValue != '\0'; ++apValue )
pBuffer[j++] = *apValue; {
} if ( isprint(*apValue) )
pBuffer[j++] = '\0'; pBuffer[j++] = *apValue;
}
pBuffer[j++] = '\0';
if ( j >= VariableNameTable[i].Min ) if ( j >= VariableNameTable[i].Min )
{ {
free(apDescriptor->pProtocol->pVariables[i]->pValueString); free(apDescriptor->pProtocol->pVariables[i]->pValueString);
apDescriptor->pProtocol->pVariables[i]->pValueString = AllocString(pBuffer); apDescriptor->pProtocol->pVariables[i]->pValueString = AllocString(pBuffer);
}
free(pBuffer);
} }
} }
} }